PR 19794 review

The PR adds the fallback to nameDisplay, but the list's Project column and the legacy masthead (which edit mode also uses) read projectDisplayName, which has none. So when the project can't be resolved, they show nothing, while the new detail header correctly shows project-monitoring.

Where it shows

• Changed by this PR: a real Project Member with a RoleBinding to read a monitor in another project's namespace. Master shows a link, but only because the getter throws. The PR leaves an empty cell whose link is zero pixels wide, so the page the PR just fixed can't be opened from the list.
• Same on master: a monitor in a namespace that isn't in a project. The list cell is empty and the edit and ?legacy=true headers stop at Project Monitor:.

Neither is the common path. A Project Member reading a monitor in their own project gets Default everywhere, so this takes custom RBAC or a namespace outside any project.

The fix, tested

shell/list/helm.cattle.io.projecthelmchart.vue
-        return {
-          ...header, value: 'projectDisplayName', labelKey: 'tableHeaders.project'
-        };
+        return { ...header, labelKey: 'tableHeaders.project' };

shell/components/ResourceDetail/Masthead/legacy.vue
-import { FLEET, NAMESPACE, MANAGEMENT, HELM } from '@shell/config/types';
+import { FLEET, NAMESPACE, MANAGEMENT } from '@shell/config/types';
-    isProjectHelmChart() {
-      return this.schema?.id === HELM.PROJECTHELMCHART;
-    },
-
-      let displayName = this.value.nameDisplay;
-
-      if (this.isProjectHelmChart) {
-        displayName = this.value.projectDisplayName;
-      }
+      const displayName = this.value.nameDisplay;

On PR + fix, the blank cell and blank headers are gone, and everything else matches the PR: header, drawer, delete dialog, export name, sort order, search and legacy view. The ten suites covering these files pass (62 tests), and lint is clean. PR 19737 edits other parts of the list file, so this shouldn't conflict with it.

The description says projectId stops throwing. What that means for a user: on master, someone who can read a monitor but not its namespace gets no title or actions on the detail page, plus a TypeError in the console. With the PR they get the normal header.

i18n.t() escapes its output by default, and these places then render it as plain text. A project called R&D shows as R&D in the Show Configuration title, and the two header aria-labels read the same way. It's generic: a ConfigMap with a free-text name does it on master too. This PR only adds project names to what can reach it, so I left it out of the suggested review. It could be its own small issue.

Nothing here renders as HTML. <b>x</b> in a project name stays literal text in the header, the delete dialog and the list.

Open Project Monitors from More Resources > Helm instead of Monitoring. It's the same on master, so it isn't in the suggested review.

Suggested review: Comment

For Cody, in your voice, using your usual shape: an intro line and one inline comment, with no code blocks and no preview link. Not posted.

Main comment

Works as described: the header, drawer, delete dialog and export all show the project now, and sorting follows it. It also brings back the header for someone who can read a monitor but not its namespace, which is missing on master. One small suggestion inline.

Inline on shell/models/helm.cattle.io.projecthelmchart.js:27

The list's Project column and the legacy masthead (also used by edit) still read projectDisplayName, so they miss this fallback. When the project can't be resolved, the list shows an empty cell with nothing to click, and the edit header stops at Project Monitor:. I hit both with a monitor in a namespace outside any project, and the list one with a Project Member who can read a monitor in another project's namespace. That user gets a link on master, but only because the getter throws there.

Could both read nameDisplay instead? That means dropping the value override in the list's header map and the isProjectHelmChart special case in the masthead. I tried it and the rest stays the same, including sorting, search and the legacy and edit headers, and the tests still pass.

Attach the two list screenshots from card 1, PR then with the change, as width-400 images.